Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

httpx: rewrite patching to use wrapt instead of subclassing client #2909

Merged
merged 19 commits into from
Oct 29, 2024
Merged

httpx: rewrite patching to use wrapt instead of subclassing client #2909

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
0dd652e
httpx: rewrote patching to use wrapt instead of subclassing client
xrmx Oct 16, 2024
06bc9b5
Remove dead code
xrmx Oct 16, 2024
cc7b97e
Handle hooks in instrument_client
xrmx Oct 17, 2024
f0de350
Update some test helper
xrmx Oct 18, 2024
b15b83c
green tests \o/
xrmx Oct 22, 2024
94295ac
check that sync hooks are callable
xrmx Oct 22, 2024
ccffa9b
Remove debug helpers
xrmx Oct 22, 2024
986f3db
remove FIXME
xrmx Oct 22, 2024
3a2706b
Reduce use of shared state in the instrumentor class
xrmx Oct 22, 2024
dfb3b48
Cast span attributes to dict when comparing against a dict
xrmx Oct 22, 2024
f356e90
Please some pylint errors
xrmx Oct 22, 2024
921162a
Add tests for subclassed clients
xrmx Oct 23, 2024
eede6a6
Add missing wrapt dependency
xrmx Oct 24, 2024
1951496
Add changelog
xrmx Oct 28, 2024
f0880e6
Merge branch 'main' into httpx-use-wrapt
emdneto Oct 28, 2024
deb4a1a
Update instrumentation/opentelemetry-instrumentation-httpx/tests/test…
xrmx Oct 28, 2024
f18b869
Update instrumentation/opentelemetry-instrumentation-httpx/src/opente…
xrmx Oct 28, 2024
f4573e3
Update instrumentation/opentelemetry-instrumentation-httpx/src/opente…
xrmx Oct 28, 2024
b373446
Apply suggestions from code review
xrmx Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
([#2871](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2871))
- `opentelemetry-instrumentation` Don't fail distro loading if instrumentor raises ImportError, instead skip them
([#2923](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2923))
- `opentelemetry-instrumentation-httpx` Rewrote instrumentation to use wrapt instead of subclassing
([#2909](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2909))

## Version 1.27.0/0.48b0 (2024-08-28)

Expand Down
1 change: 1 addition & 0 deletions instrumentation/opentelemetry-instrumentation-httpx/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ dependencies = [
"opentelemetry-instrumentation == 0.49b0.dev",
"opentelemetry-semantic-conventions == 0.49b0.dev",
"opentelemetry-util-http == 0.49b0.dev",
"wrapt >= 1.0.0, < 2.0.0",
]

[project.optional-dependencies]
Expand Down
Loading