Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add script to populate required checks list #4127

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Add script to populate required checks list #4127

merged 4 commits into from
Aug 21, 2024

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Aug 15, 2024 •
edited
Loading

Fixes #4126

We have hundreds of jobs in our CI, this script helps adding them all to the required checks in main, doing this by hand is extremely inconvenient.

@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 15, 2024
@ocelotl ocelotl self-assigned this Aug 15, 2024
@ocelotl ocelotl requested a review from a team August 15, 2024 23:41
xrmx
xrmx reviewed Aug 19, 2024
View reviewed changes
Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to add a reference to this script somewhere in CONTRIBUTING.md so people know it exists

scripts/add_required_checks.py Show resolved Hide resolved
@ocelotl ocelotl merged commit 56ad0ce into open-telemetry:main Aug 21, 2024
376 checks passed
@ocelotl ocelotl deleted the issue_4126 branch August 21, 2024 21:14
hyoinandout pushed a commit to hyoinandout/opentelemetry-python that referenced this pull request Aug 29, 2024
@ocelotl @hyoinandout
Add script to populate required checks list (open-telemetry#4127)
c086ee6 
Fixes open-telemetry#4126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrmx xrmx xrmx approved these changes

@emdneto emdneto emdneto approved these changes

@lzchen lzchen lzchen approved these changes

Assignees

@ocelotl ocelotl

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add script to populate required checks list
4 participants
@ocelotl @xrmx @emdneto @lzchen