Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: improve tox for local development #4238

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

emdneto
Copy link
Member

@emdneto emdneto commented Oct 24, 2024

Description

The changes are basically move pip install commands from commands_pre section to deps section in tox.ini.

Fixes #4237

Type of change

Please delete options that are not relevant.

  • Build & Infra

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • run tox for all commands

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@emdneto emdneto requested a review from a team as a code owner October 24, 2024 21:49
@emdneto emdneto marked this pull request as draft October 24, 2024 21:49
Signed-off-by: emdneto <[email protected]>
@emdneto emdneto added build & infra Issues related to build & infrastructure. Skip Changelog PRs that do not require a CHANGELOG.md entry labels Oct 24, 2024
@emdneto emdneto marked this pull request as ready for review October 24, 2024 21:59
tox.ini Show resolved Hide resolved
tox.ini Show resolved Hide resolved
@lzchen lzchen merged commit 897e8c9 into open-telemetry:main Oct 30, 2024
348 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build & infra Issues related to build & infrastructure. Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve tox.ini testing commands for local development
4 participants