Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add trailing slash to .toys releases.yml directory to prevent gem release mismatch #1799

Merged
merged 1 commit into from
Jan 30, 2025
Merged

fix: add trailing slash to .toys releases.yml directory to prevent gem release mismatch #1799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .toys/.data/releases.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,11 @@ gems:
version_constant: [OpenTelemetry, Exporter, Jaeger, VERSION]

- name: opentelemetry-exporter-otlp
directory: exporter/otlp
# we append a slash here to avoid the naive substring start_with? directory-matching condition in underlying toys gem
# which casues exporter/otlp to incorrectly match when changes occur in exporter/otlp-logs or exporter/otlp-metrics
# https://github.com/dazuma/toys/blob/17ed449da8299f272b834470ff6b279a59e8070b/.toys/release/.lib/release_utils.rb#L436
# https://github.com/open-telemetry/opentelemetry-ruby/issues/1792
directory: exporter/otlp/
version_constant: [OpenTelemetry, Exporter, OTLP, VERSION]

- name: opentelemetry-exporter-otlp-logs
Expand Down
Loading