Implement Exponential Histgoram metrics #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoongo
requested review from
nachoBonafonte,
bryce-b and
vvydier
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #525 +/- ##
==========================================
+ Coverage 67.41% 68.41% +0.99%
==========================================
Files 335 344 +9
Lines 14585 15151 +566
==========================================
+ Hits 9833 10365 +532
- Misses 4752 4786 +34 ☔ View full report in Codecov by Sentry. |
jhoongo
force-pushed
the
exponential-histogram-metrics
branch
4 times, most recently
from
e8b506a to
6e5e46e
Compare
nachoBonafonte
requested changes
Mar 21, 2024
Sources/OpenTelemetrySdk/Metrics/Stable/Aggregation/AdaptingCircularBufferCounter.swift
Outdated
Show resolved
Hide resolved
Sources/OpenTelemetrySdk/Metrics/Stable/Aggregation/AdaptingCircularBufferCounter.swift
Outdated
Show resolved
Hide resolved
Sources/OpenTelemetrySdk/Metrics/Stable/Data/Internal/Base2ExponentialHistogramIndexer.swift
Outdated
Show resolved
Hide resolved
Sources/OpenTelemetrySdk/Metrics/Stable/Data/Internal/ExponentialHistogramPointData.swift
Outdated
Show resolved
Hide resolved
jhoongo
force-pushed
the
exponential-histogram-metrics
branch
2 times, most recently
from
b7d34be to
562162e
Compare
jhoongo
force-pushed
the
exponential-histogram-metrics
branch
from
562162e to
f69c8b2
Compare
Thanks for the review @nachoBonafonte ! I've updated the PR with your feedback and rebase it to the latest main. Please let me know if you still have any further feedback or concern. Thanks, |
nachoBonafonte
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
ExponentialHistogrammetric in Swift SDK. Most of the implementations was inspired and driven by https://github.com/open-telemetry/opentelemetry-java SDK. It has been validated with Java SDK to ensure that it generates the same results and passes the same tests for the most part.There might be some missing area that I might have missed on this, but this should be good enough for us to starting point for supporting Exponential Histogram.
I have excluded the implementation of Exponential Histogram on the old metric and only implemented it for Stable Metrics.
Note: I just notice the spacing/indentation issue on this PR, will follow up shortly on this.Fixed the indentation issues and added few more testings