Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare stable release #130

Merged
merged 5 commits into from
Jan 27, 2025

Conversation

jack-berg
Copy link
Member

Resolves #90.

  • Remove -alpha suffix from opentelemetry-semconv artifact
  • Remove deprecated ResourceAttributes, SemanticAttributes
  • Update japicmp to generate diff for first stable release

@jack-berg jack-berg requested review from a team as code owners January 6, 2025 21:01
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

docs/apidiffs/current_vs_latest/opentelemetry-semconv.txt Outdated Show resolved Hide resolved
docs/apidiffs/current_vs_latest/opentelemetry-semconv.txt Outdated Show resolved Hide resolved
@trask
Copy link
Member

trask commented Jan 10, 2025

sorry, last question, is this preparing an RC release, or preparing a stable release?

@jack-berg
Copy link
Member Author

sorry, last question, is this preparing an RC release, or preparing a stable release?

I was thinking that we execute an RC manually, locally. Haven't thought about what (temporary?) changes would be needed to cut an RC. If I did the release locally, I was thinking I would open a branch to communicate the changes I'd be making.

Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jack-berg jack-berg merged commit 09a6578 into open-telemetry:main Jan 27, 2025
12 checks passed
@gabrieljones
Copy link

Remove deprecated ResourceAttributes, SemanticAttributes
@jack-berg

Will this be a 2.x release or is this breaking change going to occur without bumping the major version number?

@jack-berg
Copy link
Member Author

Will this be a 2.x release or is this breaking change going to occur without bumping the major version number?

This is a breaking change without bumping the major version number:

  • Breaking changes are allowed (though still taken seriously) since the artifact has the -alpha suffix. After a stable release, no breaking changes will be allowed without a major version bump.
  • This repo is versioned in lockstep with semantic-conventions, so v1.30.0 here mirrors semantic-conventions release v1.30.0. We've worked carefully with the semantic-conventions maintainers to ensure that they can't make any changes in a minor version that would necessitate a breaking change in the generated code here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stabilize opentelemetry-semconv
4 participants