…osoft#1366)

Co-authored-by: autoantwort <[email protected]>

This should have the effect of disabling this on macOS which hopefully fixes the Python2 hang.

Related: microsoft#1255

…oft#1380)

Hopefully fixes: microsoft/vcpkg#37842

Special thanks to @TrueBrain for figuring out the actual problem in microsoft#1378

Co-authored-by: Patric Stout <[email protected]>

* should be forward slashes

* add script to check for unused messages

* add messages check to pr workflow

* error if unused messages

* dont print every message every time

* remove bogus comment

* remove bogus comment

* remove bogus comment (again)

* Remove timer; add word boundry to regex;merge format and very messages job in pr.yaml

* Use JSON files instead of REGEX to declare messages

* pass artifact messages as argument

* filter out empty from unused messages

* filter out empty from unused messages

* infer path from PSScriptRoot; reuse configure in format job

* remove unused messages

* add new line at the end of ps script

* remove unused messages

* try something

* add messages.json again

---------

Co-authored-by: Javier Matos <[email protected]>
Co-authored-by: Javier Matos <[email protected]>

…/Data/_workitems/edit/128379 is fixed (microsoft#1387)

Problems were:
- the only test in e2e_ports folder, everything else in e2e-ports
- tests modify files under $VCPKG_ROOT
- Divided in two files where one enough
- Tests fail if package is already in binary cache

…ft#1367)

In microsoft/vcpkg#37563 (comment) we have an example of versions which meet the semantic versioning format but don't sort like semantic versions, so the message:

```console
PS D:\vcpkg> .\vcpkg.exe x-add-version sqlite-modern-cpp
Use the version scheme "version" rather than "version-string" in port "sqlite-modern-cpp".
Use --skip-version-format-check to disable this check.
```

is too strong. We need to explain to the user that they should only do that if the versions actually are intended to sort that way.

…27125508870. (microsoft#1393)

…28125750868. (microsoft#1394)

…29125329245. (microsoft#1395)

* Eliminate PurgeDecompressFailure.

PurgeDecompressFailure causes the files backend for binary caching to delete the zip file if it fails to decompress. The install command set this to false due to a race consideration: it's possible that a partially uploaded zip is observed when the files backend is pointed to a network share, and deleting the file because we failed to decompress it just stomps on another builder sharing that same binary cache.

It seems incorrect that this reasoning would not apply to any other commands, but most of the other commands said PurgeDecompressFailure::Yes.

This change removes the option entirely in favor of the 'No' behavior.

* Do not redundantly set Editable or Use Head to false in manifest mode.

These are already implied by the blockers on line 1075 and 1080.

* While reviewing changes to microsoft#1339 , I observed that it was strange that the abi hash depends on whether download_only is selected. After discussion with @ras0219-msft , he agreed that the ABI hash shouldn't be affected by this setting.

However, given that in download mode, we intentionally build things which do not have all their dependencies present, it would not be safe to attempt to cache or otherwise install anything in that condition.

This change removes download_only from the ABI calculation, and changes installation to only attempt to install built bits whose dependencies are all satisfied.

…01130704803. (microsoft#1398)

…crosoft#1397)

* Add support for VS 2022 using VS170COMNTOOLS environment variable

* keep existing pattern

Co-authored-by: Billy O'Neal <[email protected]>

---------

Co-authored-by: Javier Matos <[email protected]>
Co-authored-by: Billy O'Neal <[email protected]>

…02130630235. (microsoft#1401)

The `$id` fields in all JSON schemas were wrongly referring to a
non-existent `master` branch. This isn't too bad because GitHub has some
magic to fall back to the default branch when non-existent `master`
branches are requested, but it is still incorrect. Fix it.

* Fix wrong Header-only usage message

* Cherry pick tests from microsoft#1405

---------

Co-authored-by: Lily Wang <[email protected]>
Co-authored-by: Billy Robert O'Neal III <[email protected]>

Also audited for:
* Consistently following the 'IDE error format' pointing to portfile.cmake.
* Consistently referring to the correct skip policy in the error message where applicable.
* Printing paths and other information relative to ${CURRENT_PACKAGES_DIR} or similar as appropriate.
* Debug before release.
* Don't duplicate messages when a problem happens for both debug and release.

Drive by bugfix:

    if (!build_info.policies.is_enabled(BuildPolicy::ONLY_RELEASE_CRT))
    {
        error_count += check_crt_linkage_of_libs(
            build_info, false, debug_libs, debug_lib_info.value_or_exit(VCPKG_LINE_INFO), msg_sink);
    }

was wrong; ONLY_RELEASE_CRT should mean 'these should all be release', not 'we aren't even going to look at debug'.

It is fixed to:

    error_count += check_crt_linkage_of_libs(build_info.crt_linkage,
                                              build_info.policies.is_enabled(BuildPolicy::ONLY_RELEASE_CRT),
                                              debug_libs,
                                              debug_lib_info.value_or_exit(VCPKG_LINE_INFO),
                                              msg_sink);

here.

Drive-by bugfix:
EMPTY_INCLUDE_FOLDER should not block CMAKE_HELPER_PORT from checking that the include folder is, in fact, empty.

Drive-by bugfix:
        if (!violations.empty())
        {
            msg_sink.println_warning(msgPortBugRestrictedHeaderPaths);
            print_paths(msg_sink, violations);
            msg_sink.println(msgPortBugRestrictedHeaderPaths);     // <-- duplicate!
            return LintStatus::PROBLEM_DETECTED;
        }

Drive-by bugfix:
There were duplicate checks for the lib/cmake and debug/lib/cmake directories which even printed the same message; these have been merged.

Drive-by bugfix:
The existing copyright check emitted nonsense output that included full absolute paths like:
warning: The software license must be available at ${CURRENT_PACKAGES_DIR}/share/cmdline/copyright. vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/D:/b/cmdline//LICENSE")
since at least microsoft#1116
That check has been basically rewritten to use vcpkg_install_copyright if there's only one src directory, and otherwise give up and print them all

Drive-by bugfix:
Several of the outdated CRTs didn't have the debug versions listed. Also, P was duplicated and there was no R for VC6.

…09130727339. (microsoft#1419)

…12125315598. (microsoft#1428)

* Check .csh and .pl for absolute paths

* e2e test absolute path policy on script files

Just like posh-vcpkg.psm1

…se (microsoft#1210)

Between:
* microsoft#1210
* microsoft#1408

This adds the URL to normal registries use of this but doesn't repeat the URL over and over again in ci-verify-versions.

…26130446321. (microsoft#1439)

Co-authored-by: Billy Robert O'Neal III <[email protected]>

…25140548507. (microsoft#1438)

Co-authored-by: Billy Robert O'Neal III <[email protected]>

…02125338139. (microsoft#1448)

…ft#1434)

* Test ci command on malformed port manifests

* Test ci command on individual malformed port manifest

* Pass overlay port errors to OverlayProviderImpl

* Move broken-manifest overlay ports into separate dir

"e2e-ports/overlays" is in common vcpkg test args. It must not contain
ports with broken manifests where the the tool is expected to report the
error.

The tests which need these broken ports already passed an explicit
"--overlay-ports" argument which duplicated the one in @commonArgs.
That is why this commit only changes the value of the explicit argument.

* Ensure that inactive feature can have broken dependencies

…microsoft#1451)

https://dev.azure.com/twcdot/Data/_workitems/edit/128379

…17171712082. (microsoft#1458)

… are used. (microsoft#1459)

Signed-off-by: Kefu Chai <[email protected]>
Co-authored-by: Billy Robert O'Neal III <[email protected]>

…osoft#1455)

@autoantwort points out that it makes sense for those to be clickable.

He also wants us to drop the note: prefix from newlines if we aren't attached to a tty; I'm not sure if that is correct.

print_plan does 2 things. First, it formats the action plan and prints it to the console. Second, if there were removals in the plan and the intent is not recursive, it terminates vcpkg. A function named 'print' should not be terminating vcpkg.

Moreover, only one caller actually desires this terminating behavior: the install command. All other users hard coded a value of true.

This suggests that the decision to terminate should be localized to that one caller rather than spread over everything.

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>