Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added updated Newsletter, Footer & Constant File #1058

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Added updated Newsletter, Footer & Constant File #1058

merged 2 commits into from
Jul 24, 2023

Conversation

crocmons
Copy link
Collaborator

Added updated Newsletter, Footer & Constant File #659

Screenshot (31)
Screenshot (30)

@vercel
Copy link

vercel bot commented Jul 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
informatician ❌ Failed (Inspect) Jul 24, 2023 0:58am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello crocmons, thanks for rising a Pull request, your contribution is valuable to us. The maintainers will review this Pull Request and provide feedback as soon as possible. Keep the great work up!

@s2sharpit
Copy link
Member

s2sharpit commented Jul 24, 2023

Hi @crocmons,

I want to let you know that I find the recent update better overall. However, I noticed that the footer is missing the explore section with valuable links, and the newsletter section appears to have more height than necessary. Utilizing the full width for the newsletter would be a good idea. Despite that, I must say the current sections look great.

What do you think about modifying the present newsletter, like changing the background and improving the form's user interface? Your input would be much appreciated in enhancing the user experience.

@rohansx, It would be great to hear your thoughts on this suggestion.

Original Changes through this PR.
image Screenshot (31)
Screenshot (30)

@crocmons
Copy link
Collaborator Author

crocmons commented Jul 24, 2023

The Main Branch only contains these links -
Screenshot (32)

Ah, @s2sharpit, I've just added the updated files from the main branch. If you need to add something here, please feel free to do so.

@s2sharpit
Copy link
Member

I'm talking about these links mentioned in the screenshot. It has been removed in PR #798 and I found no one mentioned to remove them. Therefore, I would request you to not change the footer. BTW, you can change the codebase to use map function to reduce the repeated code.
And for Newsletter, I think we should enhance the present newsletter more by changing it's background and the UI of form. And also the present code is in tailwindcss. ☺️

Screenshot (486)

@crocmons
Copy link
Collaborator Author

Updated the code..Now the Footer looks great to me! thanks, @s2sharpit for figuring out the issue

Screenshot (33)

Copy link
Member

@s2sharpit s2sharpit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crocmons, Is there need of Footer.css file? If not, please remove the file.

@s2sharpit
Copy link
Member

s2sharpit commented Jul 24, 2023

Updated the code..Now the Footer looks great to me! thanks, @s2sharpit for figuring out the issue

Screenshot (33)

@crocmons, It looks better now, but can you match the background color of the section with the logo present in the section?

@rohansx rohansx added level2 Intermediate issue gssoc23 This label is for GirlScript summer of code labels Jul 24, 2023
@rohansx
Copy link
Collaborator

rohansx commented Jul 24, 2023

It's fine for now, you can make other necessary changes after making it live

@rohansx rohansx merged commit 97965aa into open-xyz:next-ts-tw-migrate Jul 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc23 This label is for GirlScript summer of code level2 Intermediate issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants