-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added updated Newsletter, Footer & Constant File #1058
Added updated Newsletter, Footer & Constant File #1058
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello crocmons, thanks for rising a Pull request, your contribution is valuable to us. The maintainers will review this Pull Request and provide feedback as soon as possible. Keep the great work up!
Hi @crocmons, I want to let you know that I find the recent update better overall. However, I noticed that the footer is missing the explore section with valuable links, and the newsletter section appears to have more height than necessary. Utilizing the full width for the newsletter would be a good idea. Despite that, I must say the current sections look great. What do you think about modifying the present newsletter, like changing the background and improving the form's user interface? Your input would be much appreciated in enhancing the user experience. @rohansx, It would be great to hear your thoughts on this suggestion.
|
The Main Branch only contains these links - Ah, @s2sharpit, I've just added the updated files from the main branch. If you need to add something here, please feel free to do so. |
I'm talking about these links mentioned in the screenshot. It has been removed in PR #798 and I found no one mentioned to remove them. Therefore, I would request you to not change the footer. BTW, you can change the codebase to use map function to reduce the repeated code. |
Updated the code..Now the Footer looks great to me! thanks, @s2sharpit for figuring out the issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@crocmons, Is there need of Footer.css file? If not, please remove the file.
@crocmons, It looks better now, but can you match the background color of the section with the logo present in the section? |
It's fine for now, you can make other necessary changes after making it live |
Added updated Newsletter, Footer & Constant File #659