Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing "metadata not recognised" bug #1112

Merged
merged 2 commits into from
Jul 30, 2023
Merged

Conversation

s2sharpit
Copy link
Member

Metadata is now recognised by Nextjs

@s2sharpit s2sharpit requested a review from rohansx July 28, 2023 04:47
@vercel
Copy link

vercel bot commented Jul 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
informatician ❌ Failed (Inspect) Jul 29, 2023 8:24pm
informatician-react ❌ Failed (Inspect) Jul 29, 2023 8:24pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello s2sharpit, thanks for rising a Pull request, your contribution is valuable to us. The maintainers will review this Pull Request and provide feedback as soon as possible. Keep the great work up!

@s2sharpit s2sharpit changed the title fixing metadata not recognised bug fixing "metadata not recognised" bug Jul 28, 2023
@SiddhantPawar03 SiddhantPawar03 self-requested a review July 29, 2023 08:49
@SiddhantPawar03
Copy link
Collaborator

@s2sharpit did you raised issue?

@s2sharpit
Copy link
Member Author

@SiddhantPawar03 , thank you for reaching out. I've been actively working on the migration of our website to NextJs under issue #659. This pull request aims to enhance the SEO aspects. Your feedback or assistance would be greatly appreciated.

@gitguardian
Copy link

gitguardian bot commented Jul 29, 2023

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
- Google API Key c3e05e8 utils/searchBooks.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@rohansx rohansx added level1 Beginner friendly issue gssoc23 This label is for GirlScript summer of code labels Jul 30, 2023
@rohansx rohansx merged commit dad1cf0 into open-xyz:main Jul 30, 2023
3 of 4 checks passed
@s2sharpit s2sharpit deleted the metadata branch July 30, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc23 This label is for GirlScript summer of code level1 Beginner friendly issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants