Fix createOrUpdate environment with no manager enabled

Previously, the abstract manager would still return a successful response of 204, even if the environment was not stored at all. Now, we return a "proper" 500 code if no environment manager is able to handle the request.
openHPI · Sep 28, 2024 · 11b18aa · 11b18aa
1 parent 6573a8a
commit 11b18aa
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/internal/api/environments.go b/internal/api/environments.go
@@ -128,6 +128,7 @@ func (e *EnvironmentController) createOrUpdate(writer http.ResponseWriter, reque
 	})
 	if err != nil {
 		writeInternalServerError(request.Context(), writer, err, dto.ErrorUnknown)
+		return
 	}
 
 	if created {

diff --git a/internal/environment/abstract_manager.go b/internal/environment/abstract_manager.go
@@ -49,7 +49,7 @@ func (n *AbstractManager) Get(_ context.Context, _ dto.EnvironmentID, _ bool) (r
 func (n *AbstractManager) CreateOrUpdate(_ context.Context, _ dto.EnvironmentID, _ dto.ExecutionEnvironmentRequest) (
 	bool, error,
 ) {
-	return false, nil
+	return false, dto.ErrNotSupported
 }
 
 func (n *AbstractManager) Delete(environmentID dto.EnvironmentID) (bool, error) {