Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject Execution Debug Message #507

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Inject Execution Debug Message #507

merged 1 commit into from
Nov 23, 2023

Conversation

mpass99
Copy link
Contributor

@mpass99 mpass99 commented Nov 23, 2023

for measuring the performance of the until loop of the stderr connection.

Closes #442

Accidentally, I pushed this commit directly to main.
In response, I reverted that commit on main and enabled the branch protection rule Do not allow bypassing the above settings.

@mpass99 mpass99 requested a review from MrSerth November 23, 2023 14:35
@mpass99 mpass99 self-assigned this Nov 23, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (64412e1) 75.39% compared to head (983ffe8) 75.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #507   +/-   ##
=======================================
  Coverage   75.39%   75.40%           
=======================================
  Files          39       39           
  Lines        3825     3826    +1     
=======================================
+ Hits         2884     2885    +1     
  Misses        754      754           
  Partials      187      187           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

for measuring the performance of the until loop of the stderr connection.
Copy link
Member

@MrSerth MrSerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for adding the debug statement and enabling the rule. Otherwise, just adding this one line would have been fine for me as well ;)

@MrSerth MrSerth enabled auto-merge (rebase) November 23, 2023 15:10
@MrSerth MrSerth merged commit 9646542 into main Nov 23, 2023
10 checks passed
@MrSerth MrSerth deleted the fix/#442-until-debug branch November 23, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentry: Add Debug Message
2 participants