Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Golang from 1.22 to 1.23 #658

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Update Golang from 1.22 to 1.23 #658

merged 1 commit into from
Sep 2, 2024

Conversation

MrSerth
Copy link
Member

@MrSerth MrSerth commented Aug 17, 2024

Since release 1.23, Go will automatically download a newer toolchain, if available. Hence, we don't need to specify a patch version ourselves.

Checklist from the issue:

  • the release notes for interesting changes or new features we should enable --> @mpass99 would you take over this part, please?
  • the production environment to have Go 1.23 support
  • the go.mod file, CI, potentially linter, ...
  • a previous upgrade to ensure we don't miss something important.

Fixes #648

@MrSerth MrSerth added the dependencies Pull requests that update a dependency file label Aug 17, 2024
@MrSerth MrSerth requested a review from mpass99 August 17, 2024 15:26
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.20%. Comparing base (35bbae7) to head (d3e64d0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #658   +/-   ##
=======================================
  Coverage   76.20%   76.20%           
=======================================
  Files          43       43           
  Lines        3551     3551           
=======================================
  Hits         2706     2706           
  Misses        620      620           
  Partials      225      225           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mpass99
Copy link
Contributor

mpass99 commented Aug 18, 2024

The release notes for interesting changes or new features we should enable

  • Overall, we are quite unaffected by the update

@MrSerth
Copy link
Member Author

MrSerth commented Aug 18, 2024

Overall, we are quite unaffected by the update

Sounds good!

We could enable Go Telemetry

Yes, we could theoretically. I just tried checking which data is recorded, and it doesn't seem to be too much (a few counters here and there). However, it seems to be more effective on a developer machine (since this is where the most usage of the commands happens), so I would currently tend to enable it per developer.

@MrSerth
Copy link
Member Author

MrSerth commented Aug 28, 2024

Go 1.23 was released in the PPA we use, so that we may merge and deploy this now. A staging deploy worked seamlessly.

@MrSerth
Copy link
Member Author

MrSerth commented Aug 28, 2024

We need to merge #664 first, since otherwise the pipeline won't pass.

Since release 1.23, Go will automatically download a newer toolchain, if available. Hence, we don't need to specify a patch version ourselves.
@MrSerth MrSerth merged commit f848fee into main Sep 2, 2024
11 of 12 checks passed
@MrSerth MrSerth deleted the go_1.23 branch September 2, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Go 1.23
2 participants