-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Golang from 1.22 to 1.23 #658
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #658 +/- ##
=======================================
Coverage 76.20% 76.20%
=======================================
Files 43 43
Lines 3551 3551
=======================================
Hits 2706 2706
Misses 620 620
Partials 225 225 ☔ View full report in Codecov by Sentry. |
|
Sounds good!
Yes, we could theoretically. I just tried checking which data is recorded, and it doesn't seem to be too much (a few counters here and there). However, it seems to be more effective on a developer machine (since this is where the most usage of the commands happens), so I would currently tend to enable it per developer. |
Go 1.23 was released in the PPA we use, so that we may merge and deploy this now. A staging deploy worked seamlessly. |
We need to merge #664 first, since otherwise the pipeline won't pass. |
Since release 1.23, Go will automatically download a newer toolchain, if available. Hence, we don't need to specify a patch version ourselves.
Since release 1.23, Go will automatically download a newer toolchain, if available. Hence, we don't need to specify a patch version ourselves.
Checklist from the issue:
Fixes #648