Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nomad Job Event Handling #682

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

mpass99
Copy link
Contributor

@mpass99 mpass99 commented Sep 8, 2024

for more reliant event handling.
In recent cases, we have observed Nomad not sending Allocation-stopping events but just JobDeregistered events. We add a handling of those to capture also these cases.

Closes #649

@mpass99 mpass99 self-assigned this Sep 8, 2024
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.40%. Comparing base (a035d62) to head (9e2e8b0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #682      +/-   ##
==========================================
+ Coverage   76.19%   76.40%   +0.20%     
==========================================
  Files          43       43              
  Lines        3592     3615      +23     
==========================================
+ Hits         2737     2762      +25     
+ Misses        625      624       -1     
+ Partials      230      229       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

for more reliant event handling.
In recent cases, we have observed Nomad not sending Allocation stopping events but just JobDeregistered events. We add a handling of those to capture also these cases.
Copy link
Member

@MrSerth MrSerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for adding the first event listener for job events. Now, we're also able to add new event listeners for job events more easily, if needed 👍

I've tested the behavior on staging and think it's ready to ship 🚢

@MrSerth MrSerth merged commit 6252699 into main Sep 9, 2024
12 checks passed
@MrSerth MrSerth deleted the fix/#649-jobderegisted-events branch September 9, 2024 10:15
Copy link

sentry-io bot commented Sep 9, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Environment stopped unexpectedly `` View Issue
  • ‼️ Environment stopped unexpectedly `` View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No allocation found while updateFileSystem
2 participants