-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #2713 #2714
base: development
Are you sure you want to change the base?
Fixed #2713 #2714
Conversation
… theme, ensuring consistency between the UI and the status bar.
… theme, ensuring consistency between the UI and the status bar.
… theme, ensuring consistency between the UI and the status bar.
… theme, ensuring consistency between the UI and the status bar.
@@ -144,4 +144,9 @@ dependencies { | |||
androidTestImplementation(libs.hilt.android.testing) | |||
|
|||
debugApi(libs.androidx.compose.ui.tooling) | |||
|
|||
implementation("com.google.accompanist:accompanist-systemuicontroller:0.34.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accompanist system UI controller has been deprecated, we should migrate to EdgeToEdge Api
@@ -63,7 +72,6 @@ fun MifosApp( | |||
|
|||
Scaffold( | |||
modifier = Modifier.semantics { | |||
testTagsAsResourceId = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep as it is, useful for testing
|
||
// Apply the status bar color | ||
LaunchedEffect(Unit) { | ||
systemUiController.setStatusBarColor(color = statusBarColor) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Migrate to EdgeToEdge Api
we no need to configuring it manually this should be provided by EnableEdgeToEdge Api, you could configure theme for night & dark mode like below update
create values-night folder and create
you may need to configure TopAppBar colors as well, update DarkThemeColors you may need to do some small tweaks to match these StatusBar, NavigationBar and Surface colors to same. |
Fixes #Issue_Number
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
AndroidStyle.xml
style template to your code in Android Studio.Run the unit tests with
./gradlew check
to make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.
UI Changes