Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring of webapp to consume typesript client #1831

Closed
wants to merge 1 commit into from

Conversation

PC-11-00
Copy link
Collaborator

Description

added fineract-client autogenerated services code copying from backend which were generated, these will replace custom services to autogenerated services

Related issues and discussion

#{Issue Number}

Screenshots, if any

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • If you have multiple commits please combine them into one commit by squashing them.

  • Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

@PC-11-00 PC-11-00 requested a review from vidakovic July 28, 2023 18:07
@PC-11-00
Copy link
Collaborator Author

PC-11-00 commented Aug 1, 2023

@Thanush66 This is not a proper way to contact, you should not comment unnecessary comments on the PRs, there is a proper a slack channel for the conversations : https://mifos.org/resources/community/communications/

@ghost
Copy link

ghost commented Aug 1, 2023

@PC-11-00 Okay! I pinged you on the slack channel

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

@github-actions github-actions bot added the Stale label Sep 1, 2023
@PC-11-00
Copy link
Collaborator Author

PC-11-00 commented Sep 3, 2023

/remove-lifecycle stale

@github-actions github-actions bot removed the Stale label Sep 4, 2023
@adamsaghy
Copy link
Collaborator

@PC-11-00 This is a huge PR! i am not sure what to do with this. Is there a way to do it in smaller pieces?

@PC-11-00
Copy link
Collaborator Author

@adamsaghy Actually these are autogenerated Rest APIs files, so this can't be in smaller pieces.
Firstly these files will be merged then only I will change custom APIs with these autogenerated API files
@vidakovic knows everything about them

@github-actions
Copy link

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

@github-actions github-actions bot added the Stale label Oct 22, 2023
@github-actions github-actions bot closed this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants