build: Upgrade stylelint to version 16 and fix issues #2194
+2,336
−4,811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate upgrade stylelint from version 10 to 16 and fix all the stylelint and prettier issues in scss files. The following deprecated stylistic rules are no longer supported in stylelint, and the checks are taken over by prettier: - string-quotes - max-empty-lines - max-line-length
|
@adamsaghy @alberto-art3ch do you have time to review this? After this, I will also propose pre-commit hooks for the linting, but that should probably be a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade stylelint from version 10 to 16 and fix all the stylelint and prettier issues in scss files.
Description
The changes in
.stylelintrcreflect the de facto standards that seem to be used in the project, but were not conforming to the stylelint configuration.The following deprecated stylistic rules are no longer supported in stylelint, and the checks are taken over by prettier:
To keep checking these rules, prettier is now included in the
lintscript. Since the scope of this PR is limited to SCSS, I have added the following file types to.prettierignore, to exclude them from being processed by prettier:I propose to include these in separate pull requests, since each file type will involve fixing the current non-conforming files (especially ts).
With the fixes in this PR, the commands
npx stylelint "src/**/*.scss"andnpx prettier . --checkrun without issues.Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
web-app/.github/CONTRIBUTING.md.