New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map schema.org pending properties #62

Open

nathansalter wants to merge 2 commits into openactive:master from nathansalter:map-schema-pending-properties

nathansalter commented Dec 15, 2020

Map pending properties to pending.schema.org


          Map schema.org pending properties

0d68eec

nathansalter force-pushed the map-schema-pending-properties branch from 438d6fa to 0d68eec Compare

December 15, 2020 14:35


          Merge branch 'master' into map-schema-pending-properties

5de21e2

Contributor

nickevansuk commented Feb 4, 2021

Just noting that upon further review, fixing forward and using another type of indicator for "pending" properties might be the way to go here.

Steps:

Update data models to use https://schema.org instead of http://pending.schema.org in sameAs
Test in .NET to see if that breaks things
If so add a flag "isPending" or similar to the data model and use this in the .NET generator
Other generators should be able to simply ignore that flag, and any issues that the above creates can be fixed locally
This PR may then no longer be required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet