Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix README.md #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix README.md #53

wants to merge 1 commit into from

Conversation

kimdiallo
Copy link

Source the prepared virtualenv in the Debian- and corrects the path to requirements.txt in all install instructions.

@kimdiallo
Fix README.md
da308e8 
Source the prepared virtualenv  in the Debian-  and corrects the path to requirements.txt in all  install instructions.
@Neustradamus
Copy link
Contributor

@systemcrash: What do you think?

@systemcrash
Copy link
Member

Can anyone who uses virtualenv confirm that this is the case? I never got it to install/work. So I use directly.

@m3brown
Copy link
Contributor

m3brown commented Mar 13, 2022

I do not believe the changes proposed in this PR will work, and the existing instructions are fine.

The procedure suggests the pip install commands are run from the root of the repository (which the README calls airplay2-receiver/). The requirements.txt is in the root of the repository, so there is no need for a ../ unless you're running the pip command from a subdirectory (such as docker/, or ap2/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kimdiallo @Neustradamus @systemcrash @m3brown