XML::DocumentFragment.parse supports kwargs

Related to sparklemotion#3323
openbl · Nov 14, 2024 · 9dd0946 · 9dd0946
1 parent 64bb0b1
commit 9dd0946
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/lib/nokogiri/xml/document_fragment.rb b/lib/nokogiri/xml/document_fragment.rb
@@ -11,7 +11,7 @@ class DocumentFragment < Nokogiri::XML::Node
 
       ####
       # Create a Nokogiri::XML::DocumentFragment from +tags+
-      def self.parse(tags, options = ParseOptions::DEFAULT_XML, &block)
+      def self.parse(tags, options_ = ParseOptions::DEFAULT_XML, options: options_, &block)
         new(XML::Document.new, tags, nil, options, &block)
       end
 

diff --git a/test/xml/test_document_fragment.rb b/test/xml/test_document_fragment.rb
@@ -416,6 +416,16 @@ def test_for_libxml_in_context_memory_badness_when_encountering_encoding_errors
               end
             end
 
+            it "accepts kwargs" do
+              frag = Nokogiri::XML::DocumentFragment.parse(input, options: xml_default)
+              assert_equal("<a>foo</a>", frag.to_html)
+              refute_empty(frag.errors)
+
+              assert_raises(Nokogiri::SyntaxError) do
+                Nokogiri::XML::DocumentFragment.parse(input, options: xml_strict)
+              end
+            end
+
             it "takes a config block" do
               default_config = nil
               Nokogiri::XML::DocumentFragment.parse(input) do |config|