media custom select validation fix: allow selection by index (for cus…

…tom fields)
openbroadcaster · Jun 11, 2024 · 08b4c79 · 08b4c79
1 parent 1c183ec
commit 08b4c79
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/models/media_model.php b/models/media_model.php
@@ -1210,7 +1210,10 @@ public function validate($args = [])
             $metadata_value = $item['metadata_' . $metadata_field['name']];
 
             // validate if select
-            if ($metadata_field['type'] == 'select' && $metadata_value != '' && array_search($metadata_value, $metadata_field['settings']->options) === false) {
+            // note that value can be selected by index as well, so only invalidate if neither value nor valid index is used
+            if ($metadata_field['type'] == 'select' && $metadata_value != '' 
+            && array_search($metadata_value, $metadata_field['settings']->options) === false
+            && (! ctype_digit($metadata_value) || intval($metadata_value) < 0 || intval($metadata_value) > count($metadata_field['settings']->options) )) {
                 return array(false,$item['local_id'],$metadata_field['description'] . ' value not valid.');
             }