CADC-10810 - hdf5 support for TAOSII #187
Conversation
…nge by blueprint works.
… uses metadata from a database query to create a record.
… values in blueprints.
…he same file. Set up Part creation to be instigated by subsets of extensions.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
==========================================
+ Coverage 93.56% 93.63% +0.06%
==========================================
Files 26 26
Lines 8678 8687 +9
==========================================
+ Hits 8120 8134 +14
+ Misses 558 553 -5 ☔ View full report in Codecov by Sentry. |
| # self._wcs_parsers[0] = WcsParser(obs_blueprint, extension=0) | ||
| # used to set the astropy wcs info, resulting in a validated wcs | ||
| # that can be used to construct a valid CAOM2 record | ||
| self._wcs_parsers = {} |
There was a problem hiding this comment.
Argument not required. In fact I'm not sure the entire method is required.
There was a problem hiding this comment.
This method call is over-writing the default behaviour in the ContentParser class. The default behaviour does require access to the obs_blueprint, and is called in the ContentParser constructor.
There was a problem hiding this comment.
Maybe add a comment so we (I) remember next time. Too bad Python doesn't have the @override decorator like Java has.
No description provided.