CADC-8776 update doi service int-test #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jburke-cadc
commented
Nov 26, 2024
jburke-cadc
commented
- int-tests no longer use the doiadmin user to run tests, the developer can use either a local VOSpace service they own or their home folder in a production VOSpace service.
- individual CRUD int-tests replaced with a single DOI lifecycle int-test
- intTest.properties file to set the doi service for testing and the VOSURI for the parent DOI folder in VOSpace.
andamian
reviewed
Dec 2, 2024
doi/intTest.properties
Outdated
| @@ -0,0 +1,7 @@ | |||
| # intTest.properties expects the following entries: | |||
|
|
|||
There was a problem hiding this comment.
Shouldn't this file be in src/intTest directory instead?
There was a problem hiding this comment.
Made it optional in src/int/test/resource and updated the intTest README to explain.
doi/src/intTest/README.md
Outdated
| The `doi-auth.pem` user is a member of this group, giving this user read/write access to a test DOI. | ||
| The `doi-noauth.pem` user is not a member of this group, giving this user read-only access to a test DOI. | ||
| - `doi-admin.pem` owns and has full permissions to a test DOI. | ||
| - `doi-auth.pem` has read-write permissions to a test DOI. |
There was a problem hiding this comment.
How? A group is required for that I assume.
There was a problem hiding this comment.
Yes, updated the README with a better explanation.
There was a problem hiding this comment.
Hmm. Didn't see the update.
andamian
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.