enable cavern to handle links to external files #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
all: correctly fail if attempting to navigate an external linknode in path cavern: handle absolute and relative links to external targets (eg in a separately mounted filesystem)
enable cavern to create symlink to external files from file: URI
brianmajor
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use file:///path/to/something for an external file (external to cavern root)
allow GET and PUT (create) external file links
reject all attempts to navigate external links (to directories)
reject download of an external file via files or transfer neg.
one optional create + get test added
currently no automated tests of the reject scenarios... TBD