Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release_8] Opencast Studio link enhancements: hidden Series + ACLs #396

Open
wants to merge 2 commits into
base: release_8
Choose a base branch
from

Conversation

ferishili
Copy link
Contributor

This PR fixes #382

Description

It has been requested to make it possible to pass the User ACLs also to Studio, as well as hiding the series id field in the studio!
Please refer to #382 (comment) for more info!

Solution

  • Make the query param prepration a bit more cleaner by using arrays etc.
  • Add seriesField=hidden into the query params of Studio Link
  • Add a new function: ACLtoXML->getStudioACLObjectNotation which is responsible to convert the acl entries into an acl notation object string consumable by Studio via elan-ev/opencast-studio #1212
  • Pass that ACL notation object string as "upload.acl" param to the query params string

To TEST

You would need to:

  • Patch this PR
  • Patch elan-ev/opencast-studio #1212
  • Adjust your Roles in Plugin Config > Settings > Groups & Roles
  • Make sure Studio is configured!
  • Go to a series repo object in a course with a user that has Studio Upload Right
  • Click on the Opencast Studio button
  • Make sure to upload any video in studio and validate the changes:
    • The series ID has to be "hidden" in the Studio UI upload form.
    • After the video is upload the ACLs must be presented to the Access policy list of that event as it would come from a normal video upload from ILIAS Plugin!

@ferishili ferishili added the enhancement New feature or request label Jan 17, 2025
@ferishili ferishili self-assigned this Jan 17, 2025
@ferishili ferishili changed the title Opencast Studio link enhancements: hidden Series + ACLs [Release_8] Opencast Studio link enhancements: hidden Series + ACLs Jan 17, 2025
@samuelinniger
Copy link

Additional Feature Request/ OC-Studio enhancement from the University of Berne:

  • When clicking on the Button "Opencast Studio", OC-Studio should open in a new tab. Currently it opens in the same tab. As there is no "bring me back to ILIAS" button, the user gets lost.
    (Analogue to the OC-Editor when cutting a video. The editor opens in a new tab)

@reiferschris
Copy link
Contributor

Additional Feature Request/ OC-Studio enhancement from the University of Berne:

* When clicking on the Button "Opencast Studio", OC-Studio should open in a new tab. Currently it opens in the same tab. As there is no "bring me back to ILIAS" button, the user gets lost.
  (Analogue to the OC-Editor when cutting a video. The editor opens in a new tab)

I don't disagree with this request. @samuelinniger
However, have you configured Studio to use the return.label? See here: https://github.com/elan-ev/opencast-studio/blob/master/CONFIGURATION.md (see the section [return]
In our plugin this return.label is set in the url.
Unfortunately we are somehow missing the allowedDomains so I can't confirm this works, but it should, and I've seen it working in the past.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Testing
Development

Successfully merging this pull request may close these issues.

3 participants