Fix the multiple creation of subtitle files #6475
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the creation of multiple subtitle files, when someone clicks on "save" or "save and process" multiple times without reloading or restarting the editor. The fix changes the initial uuid of the subtitle file. Instead of creating always a new and random one in the backend, we use the uuid provided by the frontend. So when clicking "save" multiple times, the backend code notices it's the same uuid and will not create new files every time.
|
This is a frontend issue that needs to be addressed: the subtitles should have their state reset to prevent resubmission. Additionally, for new subtitles, the editor should refrain from assigning an ID, as we shouldn't depend on user input to determine our entity IDs. |
|
We discussed this in the dev meeting and concluded that the IDs should be created from the backend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes opencast/opencast-editor#1550
Fixes a Bug, where multiple subtitle files get created.
How to reproduce
+How to test this patch