Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: configurable span tracking #26

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

garthk
Copy link

@garthk garthk commented Aug 5, 2019

Second attempt at implementing a configurable behaviour for span context tracking (open-telemetry/opentelemetry-erlang#4). This API shape felt more comfortable, especially how little change it took to switch with_child_span/3 across:

previous_span_ctx = Opencensus.Trace.get_span_ctx()
parent_span_ctx = Opencensus.Trace.effective_span_ctx()
new_span_ctx = :oc_trace.start_span("...", parent_span_ctx, %{...: :...})
Opencensus.Trace.put_span_ctx(new_span_ctx)
:...
:oc_trace.finish_span(new_span_ctx)
Opencensus.Trace.put_span_ctx(previous_span_ctx)

@garthk garthk changed the base branch from master to fix/span-capture-spillage-#22 August 5, 2019 10:12
@garthk garthk self-assigned this Aug 5, 2019
@codecov-io
Copy link

codecov-io commented Aug 5, 2019

Codecov Report

Merging #26 into fix/span-capture-spillage-#22 will increase coverage by 0.3%.
The diff coverage is 100%.

Impacted file tree graph

@@                       Coverage Diff                        @@
##           fix/span-capture-spillage-#22      #26     +/-   ##
================================================================
+ Coverage                          98.24%   98.55%   +0.3%     
================================================================
  Files                                  5        6      +1     
  Lines                                 57       69     +12     
================================================================
+ Hits                                  56       68     +12     
  Misses                                 1        1
Impacted Files Coverage Δ
lib/opencensus/process_context.ex 100% <100%> (ø)
lib/opencensus/trace.ex 96.87% <100%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3af2473...96f2246. Read the comment docs.

@garthk garthk force-pushed the feature/configurable-span-tracking branch from 7c057d6 to 66d4602 Compare August 6, 2019 07:47
Base automatically changed from fix/span-capture-spillage-#22 to master November 9, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants