Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution to tasks 1,3,4,5,6,7 and 9 added #59

Merged
merged 2 commits into from
Jan 30, 2018

Conversation

pani-vishal
Copy link
Contributor

Related to issues #1 #11 #12 #13 #21 #32 #49.

@gauthamzz
Copy link
Member

only change your files.
Fix the codacy issues.

@Anupam-dagar
Copy link
Contributor

why are there 94 file changes?
please make changes to only your files

@pani-vishal
Copy link
Contributor Author

I don't know what happened. I'll send a PR after sometime.

@pani-vishal
Copy link
Contributor Author

Pls review @gauthamzz. The only check which failed is telling me to avoid using urllib.urlopen, so should I try something else?
Because the program is working fine when I use it.

@gauthamzz
Copy link
Member

It’s failing checks , won’t review if it doesn’t pass checks

@gauthamzz gauthamzz merged commit 2f21254 into opencode18:master Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants