Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Full Alive Translation #126

Merged
merged 12 commits into from
Nov 1, 2023
Merged

Conversation

bollu
Copy link
Collaborator

@bollu bollu commented Oct 30, 2023

We still have some 'missing operation's, and some bugs.

@bollu bollu requested a review from alexkeizer October 30, 2023 20:24
@bollu bollu changed the title wip: implement alive translation Implement Full Alive Translation Oct 30, 2023
@bollu
Copy link
Collaborator Author

bollu commented Oct 30, 2023

https://gist.github.com/bollu/f7b0d4260069907a7a1c17ff1e0ffc0f

I must admit, fixing up this alive translation over and over again is costing a reasonable number of happy points 😭

@bollu
Copy link
Collaborator Author

bollu commented Oct 30, 2023

Failures like:

tactic 'apply' failed, failed to unify
  -1 - ?a = ?a ^^^ -1
with
  BitVec.ofInt w (Int.negSucc 0) - x0✝ = x0✝ ^^^ BitVec.ofInt w (Int.negSucc 0)

I guess need us to change elaboration strategy.

@bollu
Copy link
Collaborator Author

bollu commented Oct 30, 2023

Next error:

Translation failed with error:
	Unsuported operation 'Unsuported operation or invalid arguments 'llvm.icmp eq ''

```
./././SSA/Projects/InstCombine/LLVM/Transform.lean:411:8: error: failed to compile pattern matching, stuck at
  remaining variables: [val✝:(String)]
  alternatives:
    [] |- ["eq"] => h_1 ()
  examples:(some _)
```
… the cases handled there. Add special handling for icmp making
@tobiasgrosser tobiasgrosser merged commit a6ebadc into main Nov 1, 2023
1 check passed
@tobiasgrosser tobiasgrosser deleted the alive-auto-generated-full branch November 1, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants