Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move IntrinsicAsympototics into Core/ #96

Closed
wants to merge 2 commits into from
Closed

move IntrinsicAsympototics into Core/ #96

wants to merge 2 commits into from

Conversation

bollu
Copy link
Collaborator

@bollu bollu commented Sep 27, 2023

This will need a little finesse, to rebase the region mvar PR (#94) on top of this when the time comes.

import SSA.Projects.Tensor2D.Tensor2D
-- import SSA.Projects.InstCombine.Alive
-- import SSA.Projects.Tensor1D.Tensor1D
-- import SSA.Projects.Tensor2D.Tensor2D
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these commented?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After deleting TSSA, These no longer compile. They will be fixed in separate PRs.

@alexkeizer
Copy link
Collaborator

The diff of Framework.lean is very hard to review. Can you split it into two separate commits, one that deletes the old stuff, and another that only moves the existing experimental files into their new filepaths. That should hopefully make the rebase of #94 easier, too.

Copy link
Collaborator

@goens goens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1,109 +1,1499 @@
import Lean
import Mathlib.Tactic.NormNum
-- Investigations on asymptotic behavior of representing programs with large explicit contexts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no longer the case, no?


/-- Evaluation context. There is only one type in the semantics and that type is Val -/
abbrev Env (Val : Type) := Var → Val
import Mathlib.Tactic.Ring
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this?

## Examples
-/

namespace Examples
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should go in a different file probably, shouldn't they?

| Op.extract_slice _ _ => (fun (a,i,c) => R.slice a i c) arg.toTriple
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's up here?

@bollu
Copy link
Collaborator Author

bollu commented Oct 2, 2023

Superceded by #100, #99, #98,

@bollu bollu closed this Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants