Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTG Test Update - RT 6.1 - LLDP neighbor verification change #1887

Open
wants to merge 103 commits into
base: main
Choose a base branch
from

Conversation

octpetre
Copy link
Contributor

@octpetre octpetre commented Jul 14, 2023

This changes is required in order to correctly match the status of an LLDP neighbor based on it oc telemetry not configuration.
Resolves #587

@octpetre octpetre requested review from a team as code owners July 14, 2023 19:51
@OpenConfigBot
Copy link

OpenConfigBot commented Jul 14, 2023

Pull Request Functional Test Report for #1887 / 2457b30

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
RT-6.1: Core LLDP TLV Population
Cisco 8000E status
RT-6.1: Core LLDP TLV Population
Cisco XRd status
RT-6.1: Core LLDP TLV Population
Juniper ncPTX status
RT-6.1: Core LLDP TLV Population
Nokia SR Linux status
RT-6.1: Core LLDP TLV Population
Openconfig Lemming status
RT-6.1: Core LLDP TLV Population

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
RT-6.1: Core LLDP TLV Population
Cisco 8808 status
RT-6.1: Core LLDP TLV Population
Juniper PTX10008 status
RT-6.1: Core LLDP TLV Population
Nokia 7250 IXR-10e status
RT-6.1: Core LLDP TLV Population

Help

@coveralls
Copy link

coveralls commented Jul 17, 2023

Pull Request Test Coverage Report for Build 11459215220

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 11453300163: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

Copy link
Contributor

@jasdeep-hundal jasdeep-hundal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README suggests we need to change the structure of the test overall.

Reading it closely, it seems to imply that we need to specifically test with LLDP enabled before disabling it, and that we do not disable LLDP at the interface level for the 2nd test.

I am happy with that in a follow-up patch though, let's leave the re-opened bug open in that case though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OTG: RT-6.1: Core LLDP TLV Population
4 participants