Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding AFT Base cases #3506

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Adding AFT Base cases #3506

wants to merge 16 commits into from
+409 −0

Conversation

sudhinj
Copy link

@sudhinj sudhinj commented Oct 10, 2024

This includes the test cases for validating AFT Base path.

@sudhinj sudhinj requested a review from a team as a code owner October 10, 2024 04:35
@OpenConfigBot
Copy link

OpenConfigBot commented Oct 10, 2024 •
edited
Loading

Pull Request Functional Test Report for #3506 / fc255ee

No tests identified for validation.

Help

@coveralls
Copy link

coveralls commented Oct 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11453785033

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%
Totals Coverage Status
Change from base Build 11453300163: 0.0%
Covered Lines: 1983
Relevant Lines: 3588
💛 - Coveralls

@dplore
Copy link
Member

dplore commented Oct 10, 2024

@ElodinLaarz can you review please?

ElodinLaarz
ElodinLaarz reviewed Oct 14, 2024
View reviewed changes
Copy link
Contributor

@ElodinLaarz ElodinLaarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a first pass on the READMEs. Thanks for writing these up :)

feature/aft/aft_base/otg_tests/aft_base/README.md Show resolved Hide resolved
feature/aft/aft_base/otg_tests/aft_base/README.md Outdated Show resolved Hide resolved
feature/aft/aft_base/otg_tests/aft_base/README.md Show resolved Hide resolved
feature/aft/aft_base/otg_tests/aft_base/README.md Show resolved Hide resolved
feature/aft/aft_base/otg_tests/aft_base/README.md Show resolved Hide resolved
feature/aft/aft_base/otg_tests/aft_base/README.md Show resolved Hide resolved
feature/aft/aft_base/otg_tests/aft_prefixcounters/README.md Outdated Show resolved Hide resolved
feature/aft/aft_base/otg_tests/aft_prefixcounters/README.md Outdated Show resolved Hide resolved
feature/aft/aft_base/otg_tests/aft_prefixcounters/README.md Show resolved Hide resolved
dplore
dplore reviewed Oct 16, 2024
View reviewed changes
feature/aft/aft_base/otg_tests/aft_base/README.md Outdated Show resolved Hide resolved
feature/aft/aft_base/otg_tests/aft_base/README.md Outdated Show resolved Hide resolved
feature/aft/aft_base/otg_tests/aft_base/README.md Show resolved Hide resolved
feature/aft/aft_base/otg_tests/aft_base/README.md
IPv4/IPv6 unicast routes next hop group and next hop.

## Procedure

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you have tests here, declare a subtest heading like:

## AFT-1.1.1: AFT ipv4/6 unicast entries

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt follow, it is separated isnt it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dplore dplore dplore left review comments

@ElodinLaarz ElodinLaarz ElodinLaarz left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@ElodinLaarz ElodinLaarz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sudhinj @OpenConfigBot @coveralls @dplore @ElodinLaarz