-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fill in the narrative tables #29
Conversation
It works (kinda)! Preview from running it on cg-compliance: The formatting obviously needs some work, but I propose that we take care of that as a follow-up task, since it will likely require some modification to Masonry to provide a better API for the structured data. |
} | ||
|
||
func fillRow(row xml.Node, data opencontrols.Data, control string, section string) (err error) { | ||
// the row should have one or two cells; either way, the last one is what should be filled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this comment conflicts with the case if there were two cells. (in that case would get cellNodes[1]
@@ -25,3 +27,43 @@ func GenerateXML(wordDoc *docx.Docx) (xmlDoc *xml.XmlDocument, err error) { | |||
bytes := []byte(content) | |||
return ParseXML(bytes) | |||
} | |||
|
|||
// FillParagraph inserts the given content into the provided docx XML paragraph node. Note that newlines aren't respected - you'll need to create a new paragraph node for each. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think FillParagraph
and AddMultiLineContent
deserve to be in doc-template
but that library needs a lot love and care before this would fit there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well that could ^ be said about all the part thats do things directly with these tags.
discussion for another time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally. Thinking most of this package should move over, but would rather think about that separately.
Closes #28. Builds on #39.