Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTHER reason for correction flow is function #3920

Merged
merged 18 commits into from
Oct 26, 2022
Merged

OTHER reason for correction flow is function #3920

merged 18 commits into from
Oct 26, 2022

Conversation

yeasinhossain-dsi
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 91.94% // Head: 91.49% // Decreases project coverage by -0.44% ⚠️

Coverage data is based on head (a995d45) compared to base (1c01f12).
Patch coverage: 52.66% of modified lines in pull request are covered.

❗ Current head a995d45 differs from pull request most recent head 3e50022. Consider uploading reports for the commit 3e50022 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3920      +/-   ##
===========================================
- Coverage    91.94%   91.49%   -0.45%     
===========================================
  Files          656      656              
  Lines       114152   114016     -136     
  Branches     10354    10367      +13     
===========================================
- Hits        104952   104323     -629     
- Misses        9194     9687     +493     
  Partials         6        6              
Impacted Files Coverage Δ
...ateway/src/features/registration/type-resolvers.ts 59.05% <0.00%> (+0.53%) ⬆️
...lient/src/views/RecordAudit/ActionDetailsModal.tsx 16.92% <12.30%> (+1.18%) ⬆️
...gateway/src/features/registration/fhir-builders.ts 82.84% <43.75%> (-0.12%) ⬇️
...ent/src/views/CorrectionForm/CorrectionSummary.tsx 85.07% <66.66%> (-0.04%) ⬇️
packages/client/src/views/CorrectionForm/utils.ts 75.45% <90.90%> (+1.54%) ⬆️
packages/client/src/forms/correction/corrector.ts 99.13% <96.29%> (-0.38%) ⬇️
packages/client/src/forms/correction/reason.ts 99.11% <100.00%> (+0.02%) ⬆️
...lient/src/views/CorrectionForm/VerifyCorrector.tsx 95.70% <100.00%> (+3.24%) ⬆️
...ges/client/src/views/DataProvider/birth/queries.ts 97.35% <100.00%> (-0.01%) ⬇️
...ges/client/src/views/DataProvider/death/queries.ts 98.82% <100.00%> (+0.01%) ⬆️
... and 87 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cypress
Copy link

cypress bot commented Oct 13, 2022

Comment on lines 228 to 232
requester: String
hasShowedVerifiedDocument: Boolean
statusReason: StatusReason
reason: String
otherReason: String
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yeasinhossain-dsi I wonder if you could add some documentation about where in Task are we storing these values?

Copy link
Collaborator

@euanmillar euanmillar Oct 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zangetsu101 I think we will tackle this documentation in #3706

@euanmillar euanmillar merged commit e80cb3e into develop Oct 26, 2022
@euanmillar euanmillar deleted the ocrvs-3816 branch October 26, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants