Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency express to v4.20.0 [security] #7602

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 11, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
express (source) 4.19.2 -> 4.20.0 age adoption passing confidence

express vulnerable to XSS via response.redirect()

CVE-2024-43796 / GHSA-qw6h-vgh9-j6wx

More information

Details

Impact

In express <4.20.0, passing untrusted user input - even after sanitizing it - to response.redirect() may execute untrusted code

Patches

this issue is patched in express 4.20.0

Workarounds

users are encouraged to upgrade to the patched version of express, but otherwise can workaround this issue by making sure any untrusted inputs are safe, ideally by validating them against an explicit allowlist

Details

successful exploitation of this vector requires the following:

  1. The attacker MUST control the input to response.redirect()
  2. express MUST NOT redirect before the template appears
  3. the browser MUST NOT complete redirection before:
  4. the user MUST click on the link in the template

Severity

  • CVSS Score: 5.0 / 10 (Medium)
  • Vector String: CVSS:3.1/AV:N/AC:H/PR:N/UI:R/S:U/C:L/I:L/A:L

References

This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).


Release Notes

expressjs/express (express)

v4.20.0

Compare Source

==========

  • deps: [email protected]
    • Remove link renderization in html while redirecting
  • deps: [email protected]
    • Remove link renderization in html while redirecting
  • deps: [email protected]
    • add depth option to customize the depth level in the parser
    • IMPORTANT: The default depth level for parsing URL-encoded data is now 32 (previously was Infinity)
  • Remove link renderization in html while using res.redirect
  • deps: [email protected]
    • Adds support for named matching groups in the routes using a regex
    • Adds backtracking protection to parameters without regexes defined
  • deps: encodeurl@~2.0.0
    • Removes encoding of \, |, and ^ to align better with URL spec
  • Deprecate passing options.maxAge and options.expires to res.clearCookie
    • Will be ignored in v5, clearCookie will set a cookie with an expires in the past to instruct clients to delete the cookie

Configuration

📅 Schedule: Branch creation - "" in timezone Europe/London, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the Security label Sep 11, 2024
Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@naftis
Copy link
Collaborator

naftis commented Sep 11, 2024

Not a critical security problem! Only used by internal tools 'yarn serve' and Storybook. Therefore we can leave this for 1.7


Express is used by our client in serve-static.js

I think this file is unused nowadays as it creates this type of output

➜  client git:(develop) yarn serve
yarn run v1.22.22
$ node serve-static.js
[HPM] Proxy created: /  -> http://localhost:7070
[HPM] Proxy rewrite rule created: "^/gateway" ~> "/"
[HPM] Proxy created: /  -> http://localhost:3040/bgd
[HPM] Proxy rewrite rule created: "^/countryconfig" ~> "/"

"bgd" probably is something related to Bangladesh environments

@naftis naftis added this to the v1.7.0 milestone Sep 11, 2024
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 19 times, most recently from 5e0a859 to 2b08f29 Compare September 18, 2024 11:31
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 6 times, most recently from 81afce7 to 9725ad5 Compare September 24, 2024 11:26
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 8 times, most recently from b522ac3 to 01d5c08 Compare September 25, 2024 15:00
@tumbledwyer tumbledwyer force-pushed the renovate/npm-express-vulnerability branch from 01d5c08 to 1519b75 Compare September 30, 2024 12:34
@tumbledwyer tumbledwyer merged commit 41c7dac into develop Sep 30, 2024
22 of 23 checks passed
@tumbledwyer tumbledwyer deleted the renovate/npm-express-vulnerability branch September 30, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants