Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updateField GraphQL mutation #8291

Merged
merged 24 commits into from
Jan 24, 2025
Merged

feat: updateField GraphQL mutation #8291

merged 24 commits into from
Jan 24, 2025

Conversation

naftis
Copy link
Collaborator

@naftis naftis commented Jan 7, 2025

We need to be able to verify the informants details online via MOSIP, and show it before registrar does the decision to register a birth or a death.

This pull request:

  1. allows notifying country-config on 'sent-for-approval'
  2. allows calling a workflow endpoint to add mother.verified = true as a hidden form field
  3. allows calling a GraphQL endpoint to add mother.verified = true as a hidden form field

This comment has been minimized.

@naftis naftis added the 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it label Jan 7, 2025
@github-actions github-actions bot temporarily deployed to notify-cc-about-actions January 7, 2025 10:46 Inactive
@ocrvs-bot
Copy link
Collaborator

Your environment is deployed to https://notify-cc-about-actions.opencrvs.dev

@naftis naftis temporarily deployed to notify-cc-about-actions January 22, 2025 12:33 — with GitHub Actions Inactive
@naftis naftis temporarily deployed to notify-cc-about-actions January 22, 2025 12:39 — with GitHub Actions Inactive
@naftis naftis temporarily deployed to notify-cc-about-actions January 22, 2025 14:19 — with GitHub Actions Inactive
@naftis
Copy link
Collaborator Author

naftis commented Jan 22, 2025

@Zangetsu101 When a field agent sends a declaration, country config can catch it like this after this PR is merged.

  server.route({
    method: 'POST',
    path: '/events/BIRTH/actions/sent-notification-for-review',
    handler: (request, h) => {
      console.log('Got the information!', request.payload)
      return h.response().code(200)
    },
    options: {
      tags: ['api', 'custom-event'],
      description: 'Receives notifications on event actions'
    }
  })

This conforms the way events v2 action notifications are built
https://github.com/opencrvs/opencrvs-countryconfig/blob/develop/src/index.ts#L572

@naftis naftis requested a review from Zangetsu101 January 22, 2025 14:21
@naftis naftis temporarily deployed to notify-cc-about-actions January 22, 2025 14:26 — with GitHub Actions Inactive
@naftis naftis marked this pull request as ready for review January 23, 2025 09:02
@naftis naftis temporarily deployed to notify-cc-about-actions January 23, 2025 09:02 — with GitHub Actions Inactive
@naftis naftis requested a review from rikukissa January 23, 2025 09:03
@naftis naftis temporarily deployed to notify-cc-about-actions January 23, 2025 10:39 — with GitHub Actions Inactive
@naftis naftis changed the title feat: notify country-config on non-registration events feat: updateField GraphQL mutation Jan 24, 2025
@naftis naftis temporarily deployed to notify-cc-about-actions January 24, 2025 08:20 — with GitHub Actions Inactive
@naftis naftis temporarily deployed to notify-cc-about-actions January 24, 2025 08:36 — with GitHub Actions Inactive
@naftis naftis temporarily deployed to notify-cc-about-actions January 24, 2025 09:14 — with GitHub Actions Inactive
maybe Knip is satisfied after this
@naftis naftis temporarily deployed to notify-cc-about-actions January 24, 2025 09:23 — with GitHub Actions Inactive
@naftis naftis temporarily deployed to notify-cc-about-actions January 24, 2025 10:00 — with GitHub Actions Inactive
@naftis naftis deployed to notify-cc-about-actions January 24, 2025 11:26 — with GitHub Actions Active
@naftis naftis merged commit 4ae0c7a into develop Jan 24, 2025
73 checks passed
@Zangetsu101 Zangetsu101 deleted the notify-cc-about-actions branch January 24, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants