Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: id verification status handling, QR code validation, and error handling #8387

Merged
merged 28 commits into from
Feb 6, 2025
Merged

feat: id verification status handling, QR code validation, and error handling #8387

merged 28 commits into from
Feb 6, 2025

Conversation

tahmidrahman-dsi
Copy link
Collaborator

No description provided.

@tahmidrahman-dsi tahmidrahman-dsi self-assigned this Jan 23, 2025
@github-actions GitHub Actions
Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

euanmillar
euanmillar reviewed Jan 23, 2025
View reviewed changes
packages/components/src/IDReader/readers/QRReader/Scanner.tsx
@@ -37,34 +40,46 @@ const Scanner = (props: ScannerProps) => {
const scanner = useRef<QRScanner>()
const videoElement = useRef<HTMLVideoElement>(null)
const [qrOn, setQrOn] = useState(true)
const { onError, onScan } = props
const { onError, onScan, validator } = props
const onScanSuccess = useCallback(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tahmidrahman-dsi do you think we need similar validator functionality in the transformHttpFieldIntoRequest function for the ESignet http field?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can. We can provide a validator function to the http field which will be executed in transformHttpFieldIntoRequest that can validate the response data. However we might need a design for that error case

Copy link
Collaborator Author

@tahmidrahman-dsi tahmidrahman-dsi Jan 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if they have validated themsleves with MOSIP and we are now retrieving their data.
Then we can assume the id is valid.

I guess, we might not need validation for e-signet, then

@tahmidrahman-dsi tahmidrahman-dsi marked this pull request as ready for review January 28, 2025 09:18
@tahmidrahman-dsi tahmidrahman-dsi added the 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it label Jan 28, 2025
@github-actions github-actions bot temporarily deployed to featqr-data-error-handling January 28, 2025 11:37 Inactive
@ocrvs-bot
Copy link
Collaborator

Your environment is deployed to https://featqr-data-error-handling.opencrvs.dev

@tahmidrahman-dsi tahmidrahman-dsi temporarily deployed to featqr-data-error-handling January 30, 2025 05:55 — with GitHub Actions Inactive
@tahmidrahman-dsi tahmidrahman-dsi temporarily deployed to featqr-data-error-handling January 30, 2025 06:01 — with GitHub Actions Inactive
@tahmidrahman-dsi tahmidrahman-dsi temporarily deployed to featqr-data-error-handling January 30, 2025 07:08 — with GitHub Actions Inactive
@tahmidrahman-dsi tahmidrahman-dsi temporarily deployed to featqr-data-error-handling January 30, 2025 11:27 — with GitHub Actions Inactive
@tahmidrahman-dsi tahmidrahman-dsi temporarily deployed to featqr-data-error-handling January 31, 2025 09:12 — with GitHub Actions Inactive
@tahmidrahman-dsi tahmidrahman-dsi temporarily deployed to featqr-data-error-handling February 3, 2025 05:59 — with GitHub Actions Inactive
@tahmidrahman-dsi
chore: update id reader component UI according to the latest design u…
8d9b1d2 
…pdates

- wrap it inside an input field
- minor style updates to its ui container elements
@tahmidrahman-dsi tahmidrahman-dsi temporarily deployed to featqr-data-error-handling February 3, 2025 07:03 — with GitHub Actions Inactive
@tahmidrahman-dsi tahmidrahman-dsi temporarily deployed to featqr-data-error-handling February 3, 2025 09:04 — with GitHub Actions Inactive
@tahmidrahman-dsi tahmidrahman-dsi temporarily deployed to featqr-data-error-handling February 3, 2025 13:06 — with GitHub Actions Inactive
@tahmidrahman-dsi tahmidrahman-dsi temporarily deployed to featqr-data-error-handling February 4, 2025 06:21 — with GitHub Actions Inactive
@tahmidrahman-dsi tahmidrahman-dsi temporarily deployed to featqr-data-error-handling February 4, 2025 06:37 — with GitHub Actions Inactive
@tahmidrahman-dsi
Copy link
Collaborator Author

tahmidrahman-dsi commented Feb 4, 2025 •
edited
Loading

Amended verification banner styles

Verified

image

Authenticated

image

Failed

image

@tahmidrahman-dsi tahmidrahman-dsi temporarily deployed to featqr-data-error-handling February 4, 2025 06:48 — with GitHub Actions Inactive
@tahmidrahman-dsi tahmidrahman-dsi temporarily deployed to featqr-data-error-handling February 4, 2025 10:37 — with GitHub Actions Inactive
@tahmidrahman-dsi tahmidrahman-dsi changed the title feat: QR code validation and error handling feat: id verification status handling, QR code validation, and error handling Feb 4, 2025
@tahmidrahman-dsi tahmidrahman-dsi deployed to featqr-data-error-handling February 6, 2025 05:55 — with GitHub Actions Active
@tahmidrahman-dsi tahmidrahman-dsi removed 💅 Waiting For Review 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it labels Feb 6, 2025
@tahmidrahman-dsi
Copy link
Collaborator Author

E2E passed: https://github.com/opencrvs/e2e/actions/runs/13172730396/job/36772146114

@tahmidrahman-dsi tahmidrahman-dsi merged commit b1498c3 into develop Feb 6, 2025
73 of 74 checks passed
@naftis
Copy link
Collaborator

naftis commented Feb 6, 2025

Thanks @tahmidrahman-dsi

The flaky test always seems to be 6.2.2 Verify information on review page. I can have a look if we could make it sturdier 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naftis naftis naftis approved these changes

@euanmillar euanmillar euanmillar left review comments

@Zangetsu101 Zangetsu101 Zangetsu101 approved these changes

Assignees

@tahmidrahman-dsi tahmidrahman-dsi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tahmidrahman-dsi @ocrvs-bot @naftis @euanmillar @Zangetsu101