-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catching trpc error early before react router error boundary #8757
Conversation
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this out by throwing an error from useEventConfiguration()
, but that caused a blank white screen.
Should it show the hint and redirect to login instead, as described on the issue?
Please check now. |
@tareq89 could you attach a screenshot of the error view in the PR description please? |
If the page is not broken, then it should show StyledErrorBoundary component. If it is a 401 error, the there should be hint of redirection to login page. In order for this error to happen, you can simulate some scenarios. like:
|
Good stuff, thank you! Could you attend to the linting issues so the CI passes
|
#8756