Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events v2: Update tRPC #8772

Merged
merged 26 commits into from
Feb 27, 2025
Merged

Events v2: Update tRPC #8772

merged 26 commits into from
Feb 27, 2025

Conversation

rikukissa
Copy link
Member

@rikukissa rikukissa commented Feb 25, 2025 •
edited
Loading

Updates tRPC to the latest version to enable easier customisation of what happens before and after the default mutation and query functions of tRPC

@rikukissa rikukissa added the 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it label Feb 25, 2025
@github-actions GitHub Actions
Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@ocrvs-bot
Copy link
Collaborator

Your environment is deployed to https://update-trpc.opencrvs.dev

@rikukissa rikukissa marked this pull request as ready for review February 25, 2025 12:20
@rikukissa rikukissa requested review from makelicious, jamil314 and Keksike and removed request for makelicious and jamil314 February 26, 2025 12:41
@rikukissa rikukissa enabled auto-merge (squash) February 26, 2025 14:03
Keksike
Keksike reviewed Feb 27, 2025
View reviewed changes
Copy link
Contributor

@Keksike Keksike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems to break the declaration flow, as no declaration request is sent upon form submission. This issue occurs on both local env and deployed env

On develop the request is sent.

Screen.Recording.2025-02-27.at.9.00.02.mov

Keksike
Keksike approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@Keksike Keksike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work like a charm 👌 Nice work

packages/client/src/v2-events/features/events/useEvents/outbox.ts
function getPendingMutations<T extends DecorateMutationProcedure<any>>(
procedure: T
) {
// type MutationFn = Exclude<T['mutationFn'], undefined>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented code

@rikukissa rikukissa disabled auto-merge February 27, 2025 16:27
@rikukissa rikukissa merged commit 0af47db into develop Feb 27, 2025
10 of 11 checks passed
@rikukissa rikukissa deployed to update-trpc February 27, 2025 16:27 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keksike Keksike Keksike approved these changes

@makelicious makelicious Awaiting requested review from makelicious

@jamil314 jamil314 Awaiting requested review from jamil314

Assignees
No one assigned
Labels
🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rikukissa @ocrvs-bot @Keksike