Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent validate function from recursive calls #8780

Merged
merged 5 commits into from
Feb 26, 2025

Conversation

makelicious
Copy link
Collaborator

@makelicious makelicious commented Feb 25, 2025

No description provided.

Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@makelicious makelicious changed the title fix: add changed form to useEffect dependency fix: prevent validate function from recursive calls Feb 25, 2025
@makelicious makelicious marked this pull request as ready for review February 25, 2025 15:03
@makelicious makelicious force-pushed the fix/register-action-review-not-populated branch from 9c8c48c to dac02aa Compare February 25, 2025 15:41
Copy link
Contributor

@Keksike Keksike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixed the two bugs for me:

  • Validation action sending a ton of requests to backend
  • Register review page appearing without values

Validation still caused 2 events (see image), but definitely an improvement 💪 Excellent work!

Screenshot 2025-02-25 at 19 27 31

@makelicious makelicious merged commit 99d8cf4 into develop Feb 26, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants