Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove png images from svg certificates #371

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

naftis
Copy link
Collaborator

@naftis naftis commented Jan 21, 2025

Updated the SVG certificates not to include rasterized PNG images. This helps with filesize and the certificates scaling without getting blurry or pixelated.

Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@naftis naftis requested a review from Alta-Nel January 21, 2025 10:21
Copy link
Collaborator

@tahmidrahman-dsi tahmidrahman-dsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@naftis naftis merged commit d23df44 into develop Jan 21, 2025
2 checks passed
@naftis naftis deleted the remove-png-images-from-certificates branch January 21, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants