Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport changes in ODH manifest tests #124

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Backport changes in ODH manifest tests #124

merged 1 commit into from
Sep 22, 2023

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Sep 20, 2023 •
edited
Loading

Backport changes in ODH manifest tests

Description

Backporting changes done to make manifest PR checks green - opendatahub-io/odh-manifests#937

How Has This Been Tested?

in manifest PR check

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@sutaakar sutaakar marked this pull request as ready for review September 20, 2023 15:48
anishasthana
anishasthana approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/llgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 20, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Sep 22, 2023
@sutaakar
Copy link
Contributor Author

/retest

3 similar comments
@sutaakar
Copy link
Contributor Author

/retest

@sutaakar
Copy link
Contributor Author

/retest

@sutaakar
Copy link
Contributor Author

/retest

@anishasthana
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 22, 2023
@anishasthana anishasthana merged commit 57a1b2b into opendatahub-io:main Sep 22, 2023
2 of 3 checks passed
@sutaakar sutaakar deleted the odh-manifest-sync branch September 22, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anishasthana anishasthana anishasthana approved these changes

@jiripetrlik jiripetrlik Awaiting requested review from jiripetrlik

Assignees

@anishasthana anishasthana

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sutaakar @anishasthana