Sync main into v1.9-branch
#499
Conversation
Increase timeouts as they were too short.
Enable GHAs for v1.9-branch
This commit replaces the "placeholder" create-release.yaml file to include functionality to actually create a opendatahub-io/kubeflow release following the original manual process. The GHA can be invoked manually as a workflow from GitHub as well as invoked as part of the kubeflow-release action. `kubeflow-release.yaml` has been modified to pass in the target branch name for cutting the release. The release/tag name is **NOT** provided as the `create-release.sh` script will auto-compute what the proper tag name should be. - Please note that the tag name **can** be provided if necessary in the future... at which point the tag name would be honored as is (i.e. no "auto-incrementing" logic is performed if the tag name provided as input) `create-release.sh` will also handle auto-updating the release tag for future scenarios where we change the target branch (ex: `v1.9-branch` to `v2.0-branch`). Please see the (extensive) comments in `.github/scripts/create-release.sh` for deeper explanation on implementation. - Please note, in what may be a "controversial" decision, I have extracted the script into its own file as opposed to embedding it within the `yaml` of the action. I find it more pleasant to read/develop when the script is in its own file - and also allows code editors to be smarter in offering hints on the source. Related-to: https://issues.redhat.com/browse/RHOAIENG-15391
feat(automation): Add GitHub Action to handle creating a new release
…controller (#492) This commit integrates Codecov into our testing process by publishing our coverage report generated during `make test` to Codecov via the official `codecov/codecov-action` GHA. The `CODECOV_TOKEN` was previously uploaded to our GH repository as a secret (and copied to the Dependabot Secrets as well) by a repo admin: - https://redhat-internal.slack.com/archives/C060A5FJEAD/p1733334721701649 Please be aware of functionality **NOT** included in this initial PR (that may be added in the future): - unit test results are not being shipped to `Codecov` (even though that capability is supported) - a `.codecov.yml` file is presently not included. this could come as a fast-follow after the team gets a "feel" for `Codecov` - but I think its a bit premature to take my personal opinions to create such a file. Example `odh-dashboard` config can be seen here: - https://github.com/opendatahub-io/odh-dashboard/blob/main/.codecov.yml The `Codecov` integration was added to the `odh_notebook_controller_unit_test.yaml` GHA - which is already configured to execute on `pull_request` and `push` triggers. As such, no additional modification was necessary. :warning: It should be noted that the `make test` target was modifed to ensure the coverage files for the 2 respective invocations of `go test` wrote to unique output files to prevent information loss. `*.out` files are already ignored via `.gitignore`, so no problems there. Also, Codecov claims to support report merging automatically - so this should cause no issues: - https://docs.codecov.com/docs/merging-reports Related-to: https://issues.redhat.com/browse/RHOAIENG-11142
Add a drop down menu for choosing Sync or Release action
Adding my own GH handle (`andyatmiami`) to the `approvers` and `reviewers` section of `OWNERS`, honor alphanumeric sorting, so I can be more self-sufficient in working issues alongside the team.
…roller (#490) This commit integrates Codecov into our testing process by publishing our coverage report generated during `make test` to Codecov via the official `codecov/codecov-action` GHA. The `CODECOV_TOKEN` was previously uploaded to our GH repository as a secret (and copied to the Dependabot Secrets as well) by a repo admin: - https://redhat-internal.slack.com/archives/C060A5FJEAD/p1733334721701649 Please be aware of functionality **NOT** included in this initial PR (that may be added in the future): - unit test results are not being shipped to `Codecov` (even though that capability is supported) - a `.codecov.yml` file is presently not included. this could come as a fast-follow after the team gets a "feel" for `Codecov` - but I think its a bit premature to take my personal opinions to create such a file. Example `odh-dashboard` config can be seen here: - https://github.com/opendatahub-io/odh-dashboard/blob/main/.codecov.yml The `Codecov` integration was added to the `notebook_controller_unit_test.yaml` GHA - which is already configured to execute on `pull_request` and `push` triggers. As such, no additional modification was necessary. :warning: It should be noted that the `make test` target as configured in upstream is presently incorrect. The 2 different `go test` executions are redundant - and the 2nd invocation (targetting only the `./controller/...` scope, actually overwrites the `cover.out` file initially generated by the 1st invocation. However, the fix for this should come from upstream.. I will open up a PR against upstream at which point it will flow through to `odh` whenever its merged and we sync. Related-to: https://issues.redhat.com/browse/RHOAIENG-11142
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
But why still get this protection issue.... I can not understand, theoretically we fixed here.... openshift/release#59443 |
|
/retest |
|
Jiri, next time when you do the sync use this pipilene please: https://github.com/opendatahub-io/kubeflow/actions/workflows/kubeflow-release.yaml |
|
There's OCP-CI outage, apparently /lgtm |
|
@jiridanek: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override odh-notebook-controller-e2e |
|
@jiridanek: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jiridanek: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The mystery resolved: The issue was that we set the protection to 'false,' but we never unchecked the option 'Require status checks to pass before merging` from github. https://redhat-internal.slack.com/archives/CBN38N3MW/p1734528043715489 |
Moving changes for https://issues.redhat.com/browse/RHOAIENG-7610 into a rhoai nightly, so they can be tested.
Description
Began by trying to run GHA, but got error
How Has This Been Tested?
Merge criteria: