rfc: POC pour diviser le composant EditBouquet #145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonjourmauko
reviewed
Nov 8, 2023
| @@ -0,0 +1,68 @@ | |||
| <template> | |||
There was a problem hiding this comment.
Pourrait-on appeler ce composant DatasetProperties ? C'est le nom métier qu'on lui a donnée.
There was a problem hiding this comment.
Pas de souci, je n'étais de toute façon pas satisfaite de ce nom là. On aurait donc l'interface typescript DatasetProperties et le composant DatasetPropertiesForm ?
Je voulais aussi vous poser la question quand à l'usage de Bouquet vs Topic (ce que j'ai compris être les bouquets dans l'API datagouv ?)
5 tasks
streino
changed the title
bonjourmauko
changed the title
|
Superseded by #223 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseded by #223
RFC
Depends on #162
Related to issue #144
Context or situation
Le composant editBouquet devient trop gros pour être gérable sur le moyen terme.
Problem encountered by users
Invisible pour l'usager, mais pénible pour les dévs.
Proposal of how to solve the problem
Décomposer en plusieurs composants et sous-composants tout en gardant l'accès aux informations.
What changes
Dans la page d'acceuil s'affiche une version brute du formulaire de création/édition de bouquet.
En éditant les premiers champs, les informations sont automatiquement retranscrite dans l'étape 4 récapitulative.
En cliquant sur ajouter la donnée dans l'étape 3 :
Breaking changes
La preuve de concept est sommairement affichée dans la page d'acceuil
Technical changes