Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parametrize site name #163

Merged
merged 4 commits into from
Nov 23, 2023
Merged

feat: parametrize site name #163

merged 4 commits into from
Nov 23, 2023

Conversation

geoffreyaldebert
Copy link
Contributor

Ce que fait la PR

  • Met en variable le nom du site
  • ajoute une marianne dans le favicon.ico

Usage

Utile pour gérer les différents noms des plateformes dont ce code source sera la base (ecospheres, meteo.data.gouv.fr ...)

Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for ecospheres ready!

Name Link
🔨 Latest commit 1e6da4a
🔍 Latest deploy log https://app.netlify.com/sites/ecospheres/deploys/655e080987aa2200083acf36
😎 Deploy Preview https://deploy-preview-163--ecospheres.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@abulte abulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je l'aurais mis dans la config yaml des sites. Mais peut-être que c'est galère à injecter dans la config vite ?

Copy link
Contributor

@bonjourmauko bonjourmauko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mettre la config dans config.yaml pour garder une cohérence avec le reste/

@abulte
Copy link
Contributor

abulte commented Nov 22, 2023

We might be able to handle the config injection differently since we're now loading it in the vite config, but it should be good enough for this PR.

@abulte abulte requested a review from bonjourmauko November 22, 2023 13:56
@bonjourmauko bonjourmauko merged commit 544c716 into main Nov 23, 2023
4 checks passed
@bonjourmauko bonjourmauko deleted the feat/customize-sitename branch November 23, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants