Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(npm): fix husky et applique format #198

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Conversation

bonjourmauko
Copy link
Contributor

Relates to #191

Amélioration technique

Contexte

Lorsque je commit,
je m'attends à ce que le pre-commit hook applique npm run format.

Problème

Ce n'est pas le cas, cf. #191

Solution

Quand je commit, tout es bien formatté.

Qu'est-ce qui change ?

Modifications techniques

  • 🛠 Ajoute la racine (.) dans lint-staged.

@bonjourmauko bonjourmauko added the build Tout ce qui touche au build et CI label Nov 28, 2023
@bonjourmauko bonjourmauko self-assigned this Nov 28, 2023
Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for ecospheres ready!

Name Link
🔨 Latest commit 2081e62
🔍 Latest deploy log https://app.netlify.com/sites/ecospheres/deploys/65661dc3a6a6a1000754fc41
😎 Deploy Preview https://deploy-preview-198--ecospheres.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@abulte abulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est-ce que ce changement n'applique pas le formatage à tous les fichiers ? L'idée originale était de ne changer que les fichiers staged. Ce qui marche chez moi mais j'ai pu oublier de commiter une conf.

@bonjourmauko
Copy link
Contributor Author

Est-ce que ce changement n'applique pas le formatage à tous les fichiers ? L'idée originale était de ne changer que les fichiers staged. Ce qui marche chez moi mais j'ai pu oublier de commiter une conf.

Effectivement ! C'est réglé avec le dernier commit.

@bonjourmauko bonjourmauko changed the title build(npm): fix husky et applique npm run format build(npm): fix husky et applique format Nov 28, 2023
package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@abulte abulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎂

@bonjourmauko bonjourmauko merged commit af69b15 into main Nov 29, 2023
5 checks passed
@bonjourmauko bonjourmauko deleted the build/applique-format branch November 29, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Tout ce qui touche au build et CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants