Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refacto: api #304

Merged
merged 22 commits into from
Jan 2, 2024
Merged

refacto: api #304

merged 22 commits into from
Jan 2, 2024

Conversation

abulte
Copy link
Contributor

@abulte abulte commented Dec 21, 2023

  • Conversion des services d'API en TS et typing/linting
  • Suppression du loader dans le service d'API, la responsabilité est laissée aux composants
  • Clarification de l'API (au sens interface), notamment en supprimant les méthodes avec loader et en homogénéisant les signatures
  • Corrige des petits bugs ou des warnings de lint au fur et à mesure
  • Rend les imports '@/*' compatibles avec le support vscode de Typescript
  • Simplifie les tests en utilisant un mocker axios, migre en TS
  • Supprime le composable loader non utilisé
  • Ajoute tsc --noEmit dans la CI pour checker la compilation typescript, et corrige les erreurs pour y parvenir

La config TS prend maintenant en compte les composants Vue, ce qui amène des remontées d'erreurs de compilation (non bloquantes pour le build) via vue-tsc, cf #309. Aussi, le typing plus strict et plus complet fait remonter des incohérences dans les composants. A prendre en compte dans d'autres PR, sinon ce refacto n'aura pas de fin.

Migrated:

Copy link

netlify bot commented Dec 21, 2023

Deploy Preview for ecospheres ready!

Name Link
🔨 Latest commit 0191c42
🔍 Latest deploy log https://app.netlify.com/sites/ecospheres/deploys/658be325978df70008248586
😎 Deploy Preview https://deploy-preview-304--ecospheres.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@abulte abulte added the refactor Evolutions du code sans impact sur le produit label Dec 21, 2023
Copy link

netlify bot commented Dec 22, 2023

Deploy Preview for meteo-france ready!

Name Link
🔨 Latest commit 0191c42
🔍 Latest deploy log https://app.netlify.com/sites/meteo-france/deploys/658be3258699a9000731b629
😎 Deploy Preview https://deploy-preview-304--meteo-france.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@abulte abulte marked this pull request as ready for review December 24, 2023 12:58
@abulte abulte merged commit 1f43f47 into main Jan 2, 2024
9 checks passed
@abulte abulte deleted the refacto/api branch January 2, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Evolutions du code sans impact sur le produit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants