-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inactive users notification and deletion jobs #3274
Open
maudetes
wants to merge
14
commits into
opendatateam:master
Choose a base branch
from
maudetes:feat/notify-and-delete-inactive-users
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add inactive users notification and deletion jobs #3274
maudetes
wants to merge
14
commits into
opendatateam:master
from
maudetes:feat/notify-and-delete-inactive-users
+394
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a dedicated delete_comments arg in User DELETE API
nicolaskempf57
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working great except datagouv/data.gouv.fr#1663
…tifying the entire stock of inactive users at first go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes datagouv/data.gouv.fr#1529
Process
We have two jobs, a notification and deletion job.
notify-inactive-users
notifies all users by mail that will have their account deleted in 1 month (DAYS_BEFORE_ACCOUNT_INACTIVITY_NOTIFY_DELAY
).In this case, we set the notification date (
inactive_deletion_notified_at
) in User model.delete-inactive-users
deletes all users that are inactive and haven't logged in since notification date.It also unsets the
inactive_deletion_notified_at
if the user has logged in since.Notes
inactive_deletion_notified_at
to make sure we don't deleteaccounts that haven't been notified long enough in advance. Are we bulletproof with this logic?
We can keep user contents (discussion included).
No need to be any more explicit than this.
Added a
MAX_NUMBER_OF_USER_INACTIVITY_NOTIFICATIONS
config that should be set to a low value to get started and slowly increased.