Special case single star branch/tag constraint #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the constraint is e.g. `branches: ["*"]`, then all branch names are matched, even ones containing slashes. Before this change, e.g. `feature/foo` would not have matched.
henninggross
approved these changes
Nov 17, 2023
|
I believe the docs of the configuration need to be updated as well. I am on my phone sadly and cannot link to the specific lines, but there is a place where it is mentioned that "*" does not catch every branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the constraint is e.g.
branches: ["*"], then all branch names are matched, even ones containing slashes. Before this change, e.g.feature/foowould not have matched.Closes #691.
Tasks:
docs/designdirectory or not applicabledocsdirectory or not applicablemake test) or not applicable