4.x <- Full revision of Jenkins Pipelines, to make them work again #807
Conversation
…ndevstack/ods-quickstarters into task/upgrade-atlassian-stack
victorpablosceruelo
requested review from
metmajer,
michaelsauter,
nichtraunzer,
tbugfinder,
bljubisic,
cschweikert,
gerardcl,
hugowschneider,
sino92,
buegelbeatz,
henrjk and
stitakis
as code owners
victorpablosceruelo
removed request for
michaelsauter,
metmajer,
hugowschneider,
gerardcl,
nichtraunzer,
bljubisic,
henrjk,
buegelbeatz,
tbugfinder,
sino92 and
cschweikert
There was a problem hiding this comment.
Hi everybody, I don't know the background of this change, but since it claims to remove usage of Java 17, the removal should rather be clean and complete. In common/jenkins-agents/maven/docker/Dockerfile.centos7 I can still find yum install ... java-17-... and calling of use-j17.sh, which again I'd rather delete then breaking each line with exit 1. If java 17 should come back at a later point in time, there is still the git history, release tags, etc. with this code.
CHANGELOG.md
Outdated
| @@ -35,6 +35,7 @@ | |||
| - ODS AMI build failing due an E2E test error of ionic quickstarter ([#742](https://github.com/opendevstack/ods-quickstarters/issues/742)) | |||
| - ODS AMI build failing due an missing list of supported browsers in ionic quickstarter ([#756](https://github.com/opendevstack/ods-quickstarters/issues/756)) | |||
| - inf-terraform-aws: Fix error handling of Makefile ([#680](https://github.com/opendevstack/ods-quickstarters/issues/680)) | |||
| - Removes jcenter repositories and jdk-17 usage ([#807](https://github.com/opendevstack/ods-quickstarters/pull/807)) | |||
There was a problem hiding this comment.
isn't this also a breaking change? If so I'd move this entry to ### Modified. Also I'd rename to - Remove JCenter repositories and jdk 17 support ... or so
There was a problem hiding this comment.
I've changed it. It was an initial message. Now it is better explained.
Do you see it ok now?
There was a problem hiding this comment.
Yes. You're right. It was a breaking change.
But we found a different solution that keeps jdk 17, using Adoptium Temurin, maintained by Eclipse.
More information in the following link:
#808
|
Hi all, I not agree on removing JDK 17 support without first exploring a way to solve the idk 17 installation problem in centos 7. Was this tried out? Another observation, the title of this ticket does not match to the changes. This shouldn't be the case. |
…mon/jenkins-agents/maven/docker/Dockerfile.centos7 common/jenkins-agents/maven/docker/Dockerfile.ubi8 common/jenkins-agents/nodejs12/docker/Dockerfile.ubi8
|
Fixed the problem with JDK 17, so support of JDK 17 is back. |
victorpablosceruelo
changed the title
There was a problem hiding this comment.
I reviewed some of the changes again. Unfortunatelly I'm having problems understanding the reasoning of some of these changes (e.g. removal of jcenter). Also some of the changes don't seem to be related to the initial description of the PR (e.g. about nodejs12 and terraform). For those it might make sense to move them over into a new issue+PR. Also it would be good to have an issue that this PR is directly based on (e.g. "Full revision of Jenkins Pipelines, to make them work again" seems to point to an issue).
Thanks @victorpablosceruelo for all the work you put into this PR. Seems like you needed to try a lot of crazy stuff to get it running.
victorpablosceruelo
changed the title
|
Hi @cschweikert |
victorpablosceruelo
dismissed
cschweikert’s stale review
I did the changes requested, but GitHub says I did not do them. :S
There was a problem hiding this comment.
@victorpablosceruelo THX again for bringing this complex topic forward 😀
|
Thanks @cschweikert for your comments. I'm getting the following error in GitHub: I do not Know what to do at this point... |
|
yeah, |
The upgrade of the atlassian stack needed some modifications in quickstarters because some bugs appeared.
Tasks: