docs(deploy-mayastor): changed existing info on helm chart #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abhinandan-Purkait
approved these changes
Sep 15, 2023
| - etcd.persistence.storageClass: manual | ||
| The Mayastor Helm chart now includes the Dynamic Local Persistent Volume (LocalPV) provisioner as the default option for provisioning storage to etcd and Loki. This simplifies storage setup by utilizing local volumes within your Kubernetes cluster. | ||
| For etcd, the chart uses the `mayastor-etcd-localpv` storage class, and for Loki, it utilizes the `mayastor-loki-localpv` storage class. These storage classes are bundled with the Mayastor chart, ensuring that your etcd and Loki instances are configured to use openEbs localPV volumes efficiently. | ||
| `/var/local/{{ .Release.Name }}` paths should be persistent accross reboots. |
There was a problem hiding this comment.
Isn't it /var/local/localpv-hostpath/{{ .Release.Name}}/ ?
There was a problem hiding this comment.
@AJDatacore please amend the path, otherwise LGTM
There was a problem hiding this comment.
@AJDatacore @Abhinandan-Purkait has made some changes so now for develop it should be
/var/local/{{ .Release.Name }}
But please raise another PR for release/2.4 where it should be this path:
/var/local/localpv-hostpath/{{ .Release.Name}}/
There was a problem hiding this comment.
@tiagolobocastro Can you please approve this PR
Signed-off-by: AJ_Datacore <[email protected]>
Signed-off-by: AJ_Datacore <[email protected]>
AJDatacore
force-pushed
the
deploy-mayastor
branch
from
ee5b7a4
to
9b25c26
Compare
tiagolobocastro
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.